Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-bytes strings support for file names #109

Open
v1nc3n4 opened this issue Apr 6, 2015 · 2 comments
Open

Multi-bytes strings support for file names #109

v1nc3n4 opened this issue Apr 6, 2015 · 2 comments
Labels

Comments

@v1nc3n4
Copy link

v1nc3n4 commented Apr 6, 2015

Hi,

It seems vfsStream doesn't support multi-bytes strings for filenames. I wrote a PHPUnit test case based on it, and writing/reading files whose names contains multi-bytes characters seems erroneous, and the test case fails.
Digging in the library code, I found many single-byte *str function calls, such as substr or strlen. This should not be very hard to switch to the multi-bytes version of these functions, at least.

What is your opinion?
What about stating in the documentation that the library supports only single-bytes file names?

Thanks for your help!
Vincent

@mikey179
Copy link
Member

mikey179 commented Apr 7, 2015

I think that's something that could be improved in vfsStream. As operating system support multibyte characters in filenames, vfsStream should support this as well.

@mikey179 mikey179 added this to the 1.6.0 milestone Apr 7, 2015
@v1nc3n4
Copy link
Author

v1nc3n4 commented Apr 9, 2015

Hi Frank,

Thanks for your answer, if I find some free time, I'll try to help and provide a pull request as I have many test cases to validate changes, but immediately I can't.

BR,
Vincent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants