-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a decision on external dependencies. #25
Comments
Yeah this is a tricky question. There's another part to it as well: what to do about third-party dependencies that bolt itself has. For instance, looking at this globbing stuff, the only real sensible choice I can find to do globbing on the node side is node-glob (https://github.com/isaacs/node-glob, although it has one minor suckage in that on windows it doesn't support backslashes in paths, so we'll have to find a way to fix that because wintards will definitely pass in backslashed paths). But anyway, how do we depend on this library? Copy and package the source ourselves and ship it with bolt? Add it as a npm dependency? A couple of things come to mind:
If we fleshed this out a bit, this could provide a nice standard way of extending bolt with additional sub-commands outside of a small core set (basically init, build, test, clean). We could also add hooks into the built in sub-commands to run additional commands as part of their process. For instance, bolt build could have an option to run other commands when its done, or at other points in the process, so you could say after bolt build, run minify, css-inline. Not sure about this, just random thoughts for how to make the idea generally extensible to different tools and workflows.
I still think these should definitely be separate tools. The only question is how to integrate them with bolt. |
I am good with pulling in node-glob (and similar) to a third party directory. We don't have that luxury with everything though, and I am not sure npm or more difficult manual configuration can be avoided - for example phantom needs native components which mean anything simple is off the books. Need to think this through, but it is an obvious pain point at the moment. |
Ah native components. Yeah that's going to throw a spanner in the works as well. |
@marlimox There are a few things I am not sure about and possibly are at odds with past decisions:
The text was updated successfully, but these errors were encountered: