Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with data port timeout #459

Open
robklg opened this issue May 27, 2023 · 1 comment
Open

Issue with data port timeout #459

robklg opened this issue May 27, 2023 · 1 comment

Comments

@robklg
Copy link
Contributor

robklg commented May 27, 2023

If unFTP times out on the connection of the Passive port, then give a successive data command, it locks up the control channel.

    May 27 19:58:02.337 DEBG Control channel event Command(Pasv), seq: 12
    May 27 19:58:02.337 DEBG Control channel reply CodeAndMsg { code: EnteringPassiveMode, msg: "Entering Passive Mode (127,0,0,1,244,8)" }, seq: 12
   May 27 19:58:17.340 WARN Client did not connect to data port in time
    May 27 19:58:39.498 DEBG Control channel event Command(Nlst { path: None }), seq: 13
    May 27 19:58:39.498 DEBG Control channel reply CodeAndMsg { code: FileStatusOkay, msg: "Sending directory list" }, seq: 13
    May 27 20:00:18.388 INFO Command stream ended.
    May 27 20:00:18.388 DEBG Control channel event InternalMsg(ExitControlLoop), seq: 14
    May 27 20:00:18.388 DEBG Control channel reply None, seq: 14
    May 27 20:00:18.389 INFO Exiting control loop

We are not giving back anything over the control channel to indicate that the data port is no longer available. The data command should return a 4xx.

To reproduce:

lftp localhost:/> quote pasv
---> TYPE I
<--- 200 Always in binary mode
---> pasv
227 Entering Passive Mode (127,0,0,1,224,130)
#### Wait for "WARN Client did not connect to data port in time"
lftp localhost:/> quote list
---> list
150 Sending directory list #### unFTP is stuck for this control channel, client needs to end the control session
@robklg
Copy link
Contributor Author

robklg commented May 27, 2023

This also relates to #439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant