Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version value #74

Open
Tracked by #91
ndmlny-qs opened this issue Jan 19, 2023 · 2 comments
Open
Tracked by #91

version value #74

ndmlny-qs opened this issue Jan 19, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ndmlny-qs
Copy link
Collaborator

@mattpap or @philippjfr do you have a preferred way for updating version information? Currently the DEVGUIDE.md shows the following.

Update package version

File Entry Content
ipywidgets_bokeh/__init__.py __version__ 1.0.0dev2
ipywidgets_bokeh/kernel.py implementation_version 1.0.0dev2
ipywidgets_bokeh/package.json version 1.0.0-dev.2
setup.py version 1.0.0dev2

This is a lot of spots where one needs to update this info. I can make something that models the preferred way of propagating this info into all the requisite spots. Just point me to what you want and I'll make a PR for it.

@ndmlny-qs ndmlny-qs added the enhancement New feature or request label Jan 19, 2023
@ndmlny-qs ndmlny-qs self-assigned this Jan 19, 2023
@mattpap
Copy link
Contributor

mattpap commented Jan 24, 2023

I'm not sure what's the best way of handling this. I suppose we could have the version stored and mutated in __version__, and then used in setup.py and in implementation_version. Then package.json could be updated from __version__ during a build step.

@ndmlny-qs
Copy link
Collaborator Author

Understood, I'll look into best practices for a mixed language repo and pick one to use in a PR.

@ndmlny-qs ndmlny-qs mentioned this issue Apr 6, 2023
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants