Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter handling for patch: dependencies #466

Open
dobesv opened this issue Jun 23, 2022 · 0 comments
Open

Smarter handling for patch: dependencies #466

dobesv opened this issue Jun 23, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@dobesv
Copy link
Contributor

dobesv commented Jun 23, 2022

When I have a dependency like:

    "i18next-phrase-in-context-editor-post-processor": "patch:[email protected]#./patches/i18next-phrase-in-context-editor-post-processor+1.3.0.patch",

I can't have multiple dependencies on that package in different workspaces as the path to the patch could be different. I suppose in this case the tool needs to resolve the path to the patch and verify that the absolute paths are equal instead of doing a simple string comparison.

@bmish bmish added the bug Something isn't working label Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants