Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate: improve robustness #54

Open
ES-Alexander opened this issue May 2, 2023 · 3 comments
Open

consolidate: improve robustness #54

ES-Alexander opened this issue May 2, 2023 · 3 comments

Comments

@ES-Alexander
Copy link
Collaborator

Currently it's possible to break the consolidation cycle by adding a typo or problem to the Dockerfile of a new version of an accepted extension. That's problematic and relies excessive helicopter parenting of the repo.

The consolidation script should gracefully handle extension fetch failures, either by skipping the malformed data, and/or entirely skipping the version with the malformed Dockerfile. An error message should be printed out/logged whenever a failure/skip occurs.

@Williangalvani
Copy link
Member

my goal long term is to email the maintainers. maybe opening an issue and tagging them?

@ES-Alexander
Copy link
Collaborator Author

ES-Alexander commented May 2, 2023

Hmm, that definitely seems handy, but should also be opt-in functionality of the consolidate program, since you don't want to fire off emails and issues to heaps of people if you run it locally / run it on a PR where you happen to have broken the program itself.

Either way, the catching and handling errors step has to be implemented before we can meaningfully do something with them :-)

@Williangalvani
Copy link
Member

also, this is very related to #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants