-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Firefox Nightly] Lepton no longer loads because -moz-bool-pref is moved from @supports to @media #799
Comments
Fix: find . -type f -exec sed -i 's/@supports\b\([^{]*-moz-bool-pref\)/@media\1/g; s/-moz-bool-pref(/(-moz-bool-pref: /g' {} + If you don't understand what this does, do not just paste it into a terminal and run it! This attempts to replace text in every file in and below of the current working directory, which can break stuff if ran in the wrong directory. So if you don't know what you're doing, it's better to just don't do anything (as this issue has already been fixed) or use this instead: #799 (comment) |
Well |
Hello, I opened a PR to solve bugs. ProblemThe current implementation has created a separate file for nightly. This project already generates eight files. First, I tried the easiest way. So this was withdrawn. Okay. Then what happens if I combine files QuestionWhich do you think is better, separating the files as we do now, or combining them but doubling them? |
If there is any performance hit from doubling then separate files. If not, double the file - which will only be double until main Firefox branch receives this update? |
Firefox's style engine is so fast that it has little impact on performance.
It is certain that ESR will not affect it, so it is better to keep it until the general version of the |
Fix: `-moz-bool-pref` is moved from `@supports` to `@media` #799
#801 is merged now!! |
Thanks @jkhsjdhjs, but if your command is run by someone who doesn't fully understand it, e.g. in their home dir, it will attempt to process virtually every file they own, which is quite excessive. It would be better as something generic and CSS-specific: find ~/.mozilla/firefox/*/chrome/ -type f -name '*.css' -exec sed -i 's/@supports\b\([^{]*-moz-bool-pref\)/@media\1/g; s/-moz-bool-pref(/(-moz-bool-pref: /g' '{}' '+' |
|
Describe the bug
Lepton no longer loads in Nightly because
-moz-bool-pref
moved from@supports
to@media
.see:
Expected behavior
Lepton loads
Screenshots
No response
OS
Windows 11
OS - Others
No response
Firefox Version
v120.0a1 (2023-10-19)+
Distribution
Theme
Theme - More Info
No response
user.js
setupuser.js
setupAdditional context
Consider making a separate branch for Firefox Nightly
The text was updated successfully, but these errors were encountered: