Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v14 and publish adaptive block size ASAP #42

Open
Rav3nPL opened this issue Mar 16, 2017 · 4 comments
Open

Update to v14 and publish adaptive block size ASAP #42

Rav3nPL opened this issue Mar 16, 2017 · 4 comments

Comments

@Rav3nPL
Copy link

Rav3nPL commented Mar 16, 2017

As for now, I found logic behind your code as best way to increase block size.
Moving max block size regulation to protocol level, away from human hands is only good option to make it once and for very long time.
Block size limit need to be raised as predicted by Satoshi, and SegWit is making major step forward to scalability in micro-transctions and upgrade transaction script code.

Core code for SegWit activation should be lowered to 75% and when reached, adaptive block size should be also activated.

Combining SegWit and ABS make Bitcoin open for much wider adoption than choosing from one of those two.

Currently Core SegWit activation on 95% is impossible to reach, and BU block size regulation logic is bad from beginning, not mention bug/s found in it.

I hope that you can make your code up and running in short time, to help end this crisis.

@Rav3nPL
Copy link
Author

Rav3nPL commented Mar 18, 2017

I do realize, that activating SW under 95% is risky. Maybe when this code roll it get so much support, that reaching this limit will be possible.

@karelbilek
Copy link

karelbilek commented Mar 30, 2017

bitpay has apparently abandoned development of the bitcore/insight stack

@nimbosa
Copy link

nimbosa commented Aug 14, 2017

This has sound logic. There is an outstanding pull request here: #43 Rebase bitcore patches to 0.14.x.

@karelbilek
Copy link

karelbilek commented Aug 14, 2017

I was wrong in the previous comment; it seems bitpay is doing bitcore-related work again, but moving from bitcoind to bcoin (a javascript implementation). See https://github.com/bitpay/bitcore/tree/next , it's pretty active.

I am not sure how stable and usable that is, I don't want to speak for bitpay, I haven't tried the /next branch

We forked bitpay bitcore bitcoin core (o_O) here

https://github.com/satoshilabs/bitcoin

and here is Bitcoin ABC (= Bitcoin Cash = Bcash) with the patches

https://github.com/satoshilabs/bitcoin-abc

LarryRuane pushed a commit to LarryRuane/bitcoin that referenced this issue Dec 10, 2020
…::Decrypt

4146a31 qt, wallet: Drop unused parameter in WalletModel::setWalletEncrypted (Hennadii Stepanov)
f886a20 qt, wallet: Drop unused parameter in Wallet{Frame|View}::encryptWallet (Hennadii Stepanov)
6e95011 qt, wallet: Remove unused AskPassphraseDialog::Decrypt (Hennadii Stepanov)

Pull request description:

  Grabbed from bitpay#42 with an additional commit.

  Fix #1.

ACKs for top commit:
  MarcoFalke:
    ACK 4146a31
  promag:
    Code review ACK 4146a31.

Tree-SHA512: 6070d8995525af826ad972cf1b8988ff98af0528eef285a07ec7ba0e2e92a7a6173a19dc371de94d4b437fa10f7921166e45a081de6ed2f4306e6502aafc94ee
LarryRuane pushed a commit to LarryRuane/bitcoin that referenced this issue Dec 10, 2020
b5ef9be675 Merge #1: Merge changes from upstream
9e7f512430 Merge remote-tracking branch 'origin/master' into bitcoin-fork
1f85030246 Add support for ARM64 darwin (bitpay#43)
3bb959c982 Remove unnecessary reinterpret_cast (bitpay#42)
2e97ab26b1 Fix (unused) ReadUint64LE for BE machines (bitpay#41)
47b40d2209 Bump dependencies. (bitpay#40)
ba74185625 Move CI to Visual Studio 2019.
efa301a7e5 Allow different C/C++ standards when this is used as a subproject.
cc6d71465e CMake: Use configure_package_config_file()

git-subtree-dir: src/crc32c
git-subtree-split: b5ef9be6755a2e61e2988bb238f13d1c0ee1fa0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants