Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Variable.make #3705

Closed
lanzagar opened this issue Mar 29, 2019 · 1 comment
Closed

Remove Variable.make #3705

lanzagar opened this issue Mar 29, 2019 · 1 comment
Assignees

Comments

@lanzagar
Copy link
Contributor

lanzagar commented Mar 29, 2019

See also the following (and other) issues:
#2500, #2346, #2943, #3521

Can we remove Variable.make and solve the problems it is supposed to be solving in another way?
We were discussing with @janezd that we could try to automatically match variables when that is needed instead of reusing and changing existing objects.
For example building a model on training data and then trying to use it on new test data would have problems without make. But the model needs to transform new data into its domain (that of the training data) anyway, and could instead do that in a better way. Just map variables with the same name, type and compute_value (so that variable age with values 1-100 can't map to a normalized version with values 0-1). For discrete variables, values need special care since some can be missing in train/test data in which case we need to remap the values.

Before starting work on this, we need a better estimate of how many things would need to be changed. The main one is Table.from_table(domain2, data1) which also covers the use of transform. Then there is Table.get_column_view() and the underlying Domain operations (index, __get_item__, etc).
We also need to take care that transformations (through their use of compute_value) still work.

@lanzagar lanzagar added wishlist needs discussion Core developers need to discuss the issue labels Mar 29, 2019
@janezd
Copy link
Contributor

janezd commented Apr 5, 2019

  1. Search the code for all places that require changing (assigned to nitpicker @lanzagar).
  2. Change it.

@janezd janezd removed needs discussion Core developers need to discuss the issue wishlist labels Apr 5, 2019
@janezd janezd added the needs discussion Core developers need to discuss the issue label Apr 18, 2019
@janezd janezd removed the needs discussion Core developers need to discuss the issue label Jun 12, 2019
@janezd janezd mentioned this issue Jul 5, 2019
3 tasks
@janezd janezd closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants