Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code blocks are visually broken in the recent update #21

Open
kursorbyte opened this issue Dec 29, 2020 · 3 comments
Open

Code blocks are visually broken in the recent update #21

kursorbyte opened this issue Dec 29, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kursorbyte
Copy link

The recent update has made it so some of the code in a code block gets clipped out of the box (for example: >>>).
Additonally, when a code block ends, the following line of text doesn't have enough padding and as a result, gets slightly overlapped on the code block box.
image

Without theme:
image

One more thing:
When the fold heading or fold indent option is turned on in editor settings, the clipping stops but the code goes out of the margin on the left.
image

This theme is so beautiful, and I personally want to thank you for your hard work :)

@bennyxguo
Copy link
Owner

Thanks for the support, I will look into this issue. <3

@bennyxguo
Copy link
Owner

bennyxguo commented Jan 2, 2021

image

For this part I made it so it wont flow out of the code block, but due to the formatting of Codemirror, it gave this type of marking a natural text indentation, It's hard to make it inline of the rest of the line. (Well I gave each line a padding so ... got to find another way to fix this in the future.) For now I will leave it as this for now. @kursorbyte

This fix will be release in the next version, which will be very soon!

image

For this part where the heading goes into the code block, I designed it to be like that, I figure it's natural to leave a new line infront and behind the code block that way this will look natural. like this:

image

@bennyxguo bennyxguo self-assigned this Jan 2, 2021
@kursorbyte
Copy link
Author

@TriDiamond Alright, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants