Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports named 'module' causes issues #209

Open
magp3 opened this issue Jul 26, 2018 · 3 comments
Open

Imports named 'module' causes issues #209

magp3 opened this issue Jul 26, 2018 · 3 comments
Assignees

Comments

@magp3
Copy link

magp3 commented Jul 26, 2018

I just upgraded meteor to 1.7 and tried to replace pbastowski:[email protected] with ecmascript
and ran into this issue.

import module from "./index.js"

produces this:

var module1 = _module;
var _module;

module1.watch(require("./index.js"), {
  "default": function (v) {
    _module = v;
  }
}, 0);

Where, in my case, it gives the error "_module is not defined"

@benjamn
Copy link
Owner

benjamn commented Aug 4, 2018

I tried to write a failing test case for this, but I'm having trouble reproducing the problem. Can you provide a small reproduction, possibly in the form of a Meteor app (if that's easier)?

benjamn added a commit that referenced this issue Aug 4, 2018
benjamn added a commit that referenced this issue Aug 4, 2018
@magp3
Copy link
Author

magp3 commented Aug 28, 2018

@benjamn I created a git repository with a meteor app which reproduces this issue.
https://github.com/magp3/meteor-module-issue

@benjamn
Copy link
Owner

benjamn commented Jun 18, 2019

I believe this will be fixed by #229, once it's released (soon).

@benjamn benjamn self-assigned this Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants