Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No output until the searching is complete #189

Open
caraar12345 opened this issue Oct 8, 2021 · 5 comments
Open

No output until the searching is complete #189

caraar12345 opened this issue Oct 8, 2021 · 5 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@caraar12345
Copy link

Is your feature request related to a problem? Please describe.
It feels a tad strange to run a pyWhat command and get no output at all until it's complete. With a really large file, pyWhat can understandably take a long time; it's hard to tell if it's crashed or just working silently.

Describe the solution you'd like
Ideally, progress bars would be awesome. But not too complex; counting each individual regex as a full "unit" would work fine. By this I mean, with 100 regexes to run on a file, one regex = 1%. This translates to multiple files too if a second progress bar was used - with 8 files, 1 file is worth 12.5%.

Describe alternatives you've considered
Maybe pyWhat could output each regex as it completes it along with an initial summary of what it's going to do.
For example:

Starting pyWhat...
Regexes: 150
Amazon AWS access key ✅

Additional context
Discussed on Discord 😄

@bee-san bee-san added good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Oct 9, 2021
@tres1N
Copy link

tres1N commented Oct 10, 2021

Hey! I would definitely like to work on this issue:) Can you assign it to me?

@ghost ghost unassigned tres1N Nov 3, 2021
@ghost
Copy link

ghost commented Nov 3, 2021

Unassigned due to no activity.

@ghost
Copy link

ghost commented Nov 19, 2021

A little update on this issue😅.
I suggest making identify method a generator. This way a user can call it and get an instant match. The problem is that sorting code may need changes. The same applies to printing. I am not sure about displaying status, maybe we should convert the position of the first character in a match to the percentage (compare it with the total length of input).

@definitelynotchirag
Copy link

@caraar12345 @amadejpapez Hey can i work on this if still an issue?

@caraar12345
Copy link
Author

Hey can i work on this if still an issue?

@bee-san would be the person to ask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants