Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static map images for selected routes #83

Open
7 tasks
mayurvir opened this issue Apr 17, 2024 · 0 comments · May be fixed by #89
Open
7 tasks

Add static map images for selected routes #83

mayurvir opened this issue Apr 17, 2024 · 0 comments · May be fixed by #89
Assignees
Labels
enhancement New feature or request

Comments

@mayurvir
Copy link
Contributor

mayurvir commented Apr 17, 2024

Description

Note : This issue applies to this ongoing PR. It should be taken only once this PR has been merged to main.

In the new structure that has been added in the PR given above, the functionality to show static map image with the selected route that is currently functional in the main branch was removed. This was to ensure that the base framework works properly.

Once the ongoing PR has been merged, this functionality needs to be added back to the agent but with some improvements. Here is what is required:

  1. Static maps to be shared differently for whatsapp interactions and normal API interactions. For whatsapp interactions, it should use twilio media to send the image url while for regular APIs, it should send the url directly (for e.g. in case of custom GPT)
  2. Static map images to be shared on the following occasions:
    2.1. When list of routes is asked, it should show all routes in different colors
    2.2. When a route is selected, it should show the selected route along with a link to navigate
    2.3. If a search along the route is triggered, it should show items on the map with map markers

Goals

  • When a get_routes function is triggered, return the static image with all the paths marked in different colors
  • When a select_route function is triggered, return the static image with the selected path and navigation link
  • When a perform_beckn_action is triggered with search along the route, return the static image with providers marked on the map

Expected Outcome

The /webhook endpoint should accurately return static image url in case of both whatsapp and non-whatsapp based interaction for each of the given cases.

Example of how it should look from the old implementation:
Screenshot 2024-04-18 at 1 56 17 PM

Acceptance Criteria

  • When a user asks to show routes, it should list down the routes along with a static image that shows all the routes in different colors
  • When a user selects a route, it should return the image of selected route and a link to navigate
  • When a user searches along a route, it should return an image of selected route and items marked on the static image.
  • When a user does not search along a route, it should not return the static image

Implementation Details

[List any technical details about the proposed implementation, including any specific technologies that will be used.]

Mockups / Wireframes

[Include links to any visual aids, mockups, wireframes, or diagrams that help illustrate what the final product should look like. This is not always necessary, but can be very helpful in many cases.]


[Please note that the below section of the ticket has to be in the format as mentioned as it is key to enabling proper listing of the project. Please only choose the options mentioned under the headings wherever applicable.]

Product Name

[Product Name: For eg: Beckn, Sunbird Obsrv etc]

Project Name

[Project Name: Descriptive of the ticket]

Organization Name:

[Organization Name]

Domain

[Area of governance]

Tech Skills Needed:

[Required technical skills for the project]

Complexity

Pick one of [High]/[Medium]/[Low]

Category

Pick one or more of [CI/CD], [Integrations], [Performance Improvement], [Security], [UI/UX/Design], [Bug], [Feature], [Documentation], [Deployment], [Test], [PoC]

Sub Category

Pick one or more of [API], [Database], [Analytics], [Refactoring], [Data Science], [Machine Learning], [Accessibility], [Internationalization], [Localization], [Frontend], [Backend], [Mobile], [SEO], [Configuration], [Deprecation], [Breaking Change], [Maintenance], [Support], [Question], [Technical Debt], [Beginner friendly], [Research], [Reproducible], [Needs Reproduction].

@mayurvir mayurvir added the enhancement New feature or request label Apr 17, 2024
@mayurvir mayurvir changed the title Add static maps for whatsapp conversations Add static map images for selected routes Apr 17, 2024
@mayurvir mayurvir linked a pull request Apr 19, 2024 that will close this issue
6 tasks
@mayurvir mayurvir linked a pull request Apr 19, 2024 that will close this issue
6 tasks
@mayurvir mayurvir self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant