Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry SDK Integration with the protocol server #104

Open
yravinderkumar33 opened this issue Mar 11, 2024 · 3 comments
Open

Telemetry SDK Integration with the protocol server #104

yravinderkumar33 opened this issue Mar 11, 2024 · 3 comments
Labels
enhancement New feature or request protocol server protocol server

Comments

@yravinderkumar33
Copy link

yravinderkumar33 commented Mar 11, 2024

Issue: Generate the telemetry based on Open Network Telemetry Specification(based on OTel Spec(https://opentelemetry.io/docs/specs/otel/)), which is a standardized telemetry specification for open, decentralized networks/protocols to enable network observability.

Open Network Telemetry Specifications: https://docs.google.com/document/d/1pG6nPQnR44EblckUmD6UdwJ5TrCjYQMjOdEBdNZ0V9I/edit#heading=h.jjzj6d1569a5

Resolution: We built a JS SDK to generate the telemetry (https://github.com/Sunbird-Obsrv/open-network-telemetry). SDK Documentation: https://github.com/Sunbird-Obsrv/open-network-telemetry/blob/main/README.md

Made changes in the protocol server to use the SDK and generate telemetry.

@yravinderkumar33
Copy link
Author

#103

@vbabuEM
Copy link
Contributor

vbabuEM commented Mar 13, 2024

@faizmagic can you please validate this request from a business point of view. @yravinderkumar33 has already implemented it in the PR that is linked above.

@faizmagic faizmagic added protocol server protocol server enhancement New feature or request labels Apr 16, 2024
@vbabuEM
Copy link
Contributor

vbabuEM commented May 22, 2024

@yravinderkumar33 , can you please write a brief description on what the enhancements will be if this PR is integrated, so Faiz can get a overview to approve this requirements. Primarily from a functional point of view (additional data that will be captured etc) and non-functional if any (cache improvement/code maintainability etc)

@vbabuEM vbabuEM removed their assignment May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request protocol server protocol server
Projects
None yet
Development

No branches or pull requests

3 participants