Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some sort of User Styles / User Config #62

Open
druskus20 opened this issue Dec 26, 2022 · 0 comments
Open

Implement some sort of User Styles / User Config #62

druskus20 opened this issue Dec 26, 2022 · 0 comments
Labels
discussion Topics that needs design / architecture discussions topic-frontend Things that relate to the frontend in general
Milestone

Comments

@druskus20
Copy link
Member

At the moment we have a Theme object that we pass around to our components. Its properties are then used as inline styles in the DOM elements. This clearly does not scale as the number of config options grows over time.

 <div
    style:position="absolute"
    style:height="{height}px"
    style:top="0"
    style:background={theme.editor_background}
    style:width="{theme.text_offset}px"
    style:left="{gutter_width}px"
  />

I think we could instead have a global styles.css file that is either exposed to the user or generated from its user settings, which would clean up the component code a lot.

@druskus20 druskus20 assigned druskus20 and unassigned druskus20 Dec 26, 2022
@druskus20 druskus20 added topic-frontend Things that relate to the frontend in general discussion Topics that needs design / architecture discussions labels Dec 26, 2022
@elkowar elkowar moved this to Todo in Bazed itor Dec 27, 2022
@elkowar elkowar added this to the Kinda comfy milestone Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Topics that needs design / architecture discussions topic-frontend Things that relate to the frontend in general
Projects
Status: Todo
Development

No branches or pull requests

2 participants