-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement syntax highlighting as part of core #128
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: buffet <[email protected]>
Signed-off-by: cpli <[email protected]>
Also allows `Document` to open multiple buffers at once.
Signed-off-by: buffet <[email protected]>
this manages preserving guarantees of mapping carets to regions
This represents any operations the user performs on a buffer
* feat(rekuho): introduce webui prototype A naive editor placing list of spans manually by px. Co-authored-by: Pedro Burgos <[email protected]> Signed-off-by: cpli <[email protected]> * feat(rekuho): determine XY position of a character Signed-off-by: cpli <[email protected]> * refactor(rekuho): `line_height` from theme to code In VSCode there is an arbitrary "editor.lineHeight" configuration variable allowing to multiply the line height calculated from font size. That is braindead. buffet: "git must be so lonely" I'm trying to understand it. Signed-off-by: cpli <[email protected]> * refactor(rekuho): move into `LinearAlgebra.ts` Signed-off-by: cpli <[email protected]> * legal(kanagawa): attribute kanagawa to Tommaso Laurenzi Signed-off-by: cpli <[email protected]> * chore(rekuho/npm): update package-lock.json * chore(rehuko): rename to `Vector2` for specificity Signed-off-by: cpli <[email protected]> * refactor(rekuho): move example into `Theme.ts` Signed-off-by: cpli <[email protected]> * fix(rekuho): everything Signed-off-by: cpli <[email protected]> Co-authored-by: Pedro Burgos <[email protected]>
Signed-off-by: buffet <[email protected]>
Signed-off-by: buffet <[email protected]>
Signed-off-by: buffet <[email protected]>
Removes column data from View, as we decided that we're not gonna care about that for now
removes OpenDocument and the whole ViewOpenedResponse stuff, as there's no reason the frontend should be the one initiating a view-open.
This fixes RUSTSEC-2023-0001 for us. Signed-off-by: buffet <[email protected]>
…itor#90) This is temporary, until we have proper session management and state management -- for now, mainly desirable such that frontend-development doesn't need to manually restart the backend after every change.
Signed-off-by: buffet <[email protected]>
elkowar
added
topic-core
Things related to the editor core
topic-frontend
Things that relate to the frontend in general
labels
Feb 4, 2023
elkowar
force-pushed
the
syntax-highlighting
branch
2 times, most recently
from
February 5, 2023 14:15
360a672
to
f54ca17
Compare
Also adds the respective information to the RPC protocol
elkowar
force-pushed
the
syntax-highlighting
branch
from
February 11, 2023 08:38
30c18eb
to
4db3989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic-core
Things related to the editor core
topic-frontend
Things that relate to the frontend in general
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements syntax highlighting as part of core using syntect -- later we'll want to put this in a plugin and move to also supporting treesitter.