Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement syntax highlighting as part of core #128

Closed
wants to merge 114 commits into from

Conversation

elkowar
Copy link
Contributor

@elkowar elkowar commented Feb 4, 2023

This PR implements syntax highlighting as part of core using syntect -- later we'll want to put this in a plugin and move to also supporting treesitter.

buffet and others added 30 commits December 14, 2022 21:46
Signed-off-by: buffet <[email protected]>
Signed-off-by: cpli <[email protected]>
Also allows `Document` to open multiple buffers at once.
this manages preserving guarantees of mapping carets to regions
This represents any operations the user performs on a buffer
* feat(rekuho): introduce webui prototype

A naive editor placing list of spans manually by px.

Co-authored-by: Pedro Burgos <[email protected]>
Signed-off-by: cpli <[email protected]>

* feat(rekuho): determine XY position of a character

Signed-off-by: cpli <[email protected]>

* refactor(rekuho): `line_height` from theme to code

In VSCode there is an arbitrary "editor.lineHeight" configuration
variable allowing to multiply the line height calculated from font size.

That is braindead.

buffet: "git must be so lonely"
I'm trying to understand it.

Signed-off-by: cpli <[email protected]>

* refactor(rekuho): move into `LinearAlgebra.ts`

Signed-off-by: cpli <[email protected]>

* legal(kanagawa): attribute kanagawa to Tommaso Laurenzi

Signed-off-by: cpli <[email protected]>

* chore(rekuho/npm): update package-lock.json

* chore(rehuko): rename to `Vector2` for specificity

Signed-off-by: cpli <[email protected]>

* refactor(rekuho): move example into `Theme.ts`

Signed-off-by: cpli <[email protected]>

* fix(rekuho): everything

Signed-off-by: cpli <[email protected]>
Co-authored-by: Pedro Burgos <[email protected]>
Signed-off-by: buffet <[email protected]>
Removes column data from View, as we decided that we're not gonna
care about that for now
gwimm and others added 20 commits January 9, 2023 00:29
removes OpenDocument and the whole ViewOpenedResponse stuff,
as there's no reason the frontend should be the one initiating
a view-open.
This fixes RUSTSEC-2023-0001 for us.

Signed-off-by: buffet <[email protected]>
…itor#90)

This is temporary, until we have proper session management
and state management -- for now, mainly desirable such that
frontend-development doesn't need to manually restart the backend
after every change.
@elkowar elkowar linked an issue Feb 4, 2023 that may be closed by this pull request
@elkowar elkowar added topic-core Things related to the editor core topic-frontend Things that relate to the frontend in general labels Feb 4, 2023
@elkowar elkowar force-pushed the syntax-highlighting branch 2 times, most recently from 360a672 to f54ca17 Compare February 5, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-core Things related to the editor core topic-frontend Things that relate to the frontend in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement syntax highlighting in core
6 participants