Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using versionbot, wait until versionbot has been merged to finalize the release #184

Open
pipex opened this issue Jul 13, 2022 · 3 comments

Comments

@pipex
Copy link
Contributor

pipex commented Jul 13, 2022

When using versionbot, this is how the action interacts with that service

  1. On PR: versionbot creates a branch with the version. The action uses that branch to create the release
  2. On merge: bulldozer merges the original branch (without the version bump). The action finalizes the release
  3. Versionbot runs one more time, and creates a new commit with the version bump.

If step 3 fails, the release version will get out of sync with the code version (e.g. release may be 2.0.1+rev1, while the repository is still at 2.0.0).

Moving the release finalization to step 3, when versionbot: true should address the issue.

@20k-ultra
Copy link
Contributor

#181 would solve this. We could make the trigger a PR like we currently do but make the trigger for finalize a commit by versionbot... I'll have to think about this more but it's pushing it for scope of this action to make up for issues in versionbot I think. (I want to fix it, don't think i'm trying to get off the hook.

@20k-ultra
Copy link
Contributor

I think the easiest and best solution is to have an action that checks if versionbot ran. This new action looks at the main branch and since we know Versionbot commit is always after bulldoze we can just find the latest merge commit in the timeline and look for a versionbot commit after it.

@pipex
Copy link
Contributor Author

pipex commented Jul 14, 2022

Right, I agree #181 would address this. In that scenario, since the versionbot action is configured, the result of the action will be false in the bulldozer merge, but it will be true on the versionbot merge, thus, ensuring the finalize is done at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants