Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dynamic swap fees #140

Open
garethfuller opened this issue Nov 4, 2024 · 2 comments
Open

Handle dynamic swap fees #140

garethfuller opened this issue Nov 4, 2024 · 2 comments
Labels
v3
Milestone
V3 Support

Comments

@garethfuller
Copy link
Contributor

garethfuller commented Nov 4, 2024 •
edited
Loading

For pools where hook. shouldCallComputeDynamicSwapFee == true hide swap fee data and replace with icon that represents dynamic swap fees.
@garethfuller garethfuller added the v3 label Nov 4, 2024
@garethfuller garethfuller added this to the V3 Support milestone Nov 4, 2024
@uiuxxx
Copy link
Contributor

uiuxxx commented Nov 5, 2024 •
edited
Loading

Designs:

https://www.figma.com/design/stjMSRgYKmzmau9InfKbCh/V3-new-styles?node-id=7714-455&t=voSnyNAben1LuqkR-1

Swap fees should be positioned last (after any hooks).

Grab the dynamic fees icon from here:

Dynamic fees SVG

@garethfuller
Copy link
Contributor Author

Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3
Projects
None yet
Milestone
V3 Support
Development

No branches or pull requests
2 participants
@garethfuller @uiuxxx