Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX_IN_RATIO bug #107

Open
agualis opened this issue Oct 28, 2024 · 0 comments
Open

MAX_IN_RATIO bug #107

agualis opened this issue Oct 28, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@agualis
Copy link
Collaborator

agualis commented Oct 28, 2024

Ran into it while testing a PR of mine which checks for certain PriceImpactQuery errors for v2 in the front-end.
(testing specifically with V3 pools)

John: So error is actually because of _MAX_IN_RATIO when doing a querySwapSingleTokenExactIn (see step 6 in particular here https://www.notion.so/Price-Impact-49545b95b98243e3ae624be6bcea2700?pvs=4). I don't have a great intuition for the process/maths here at the moment so this would likely take me quite a bit of time to figure out. Do you have any idea how common this bug is?

@agualis agualis self-assigned this Oct 28, 2024
@agualis agualis added this to the V3 Support milestone Oct 28, 2024
@agualis agualis added the v3 label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant