Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollback ringbuffer patch #61

Open
apprehensions opened this issue Apr 6, 2022 · 1 comment
Open

scrollback ringbuffer patch #61

apprehensions opened this issue Apr 6, 2022 · 1 comment

Comments

@apprehensions
Copy link

https://st.suckless.org/patches/scrollback/st-scrollback-ringbuffer-0.8.5.diff
i personally don't know the differences between this new scrollback patch that uses a ring buffer.
t is also said that it is "more efficient" in scrolling.
and if this is quite better, is there a way to port the column reform patch to this ringbuffer scrollback patch? and also add it to st-flexipatch?

@bakkeby
Copy link
Owner

bakkeby commented Apr 8, 2022

I'd assume that the difference would be how the scrollback logic works internally and that from an end user's point of view there would be no noticeable difference between the two.

I tried the patch and it seems to work and it doesn't allow you to scroll further up than there is buffer.

I didn't have any luck getting mouse scrolling work with this patch for whatever reason.

The columns patch is a rather invasive one and not sure how easy it would be to integrate that with this new ringbuffer patch (as the column patch is largely designed around / with the original scrollback patch I presume).

The columns reflow patch is at least three times as invasive as the columns patch, so this sounds both painful and less likely.

Using tmux (which st seems to be designed around) makes all of the aforementioned patches redundant although scrolling may be a bit more of a hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants