Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access to old state to NewsPublisher and PostProcessor #88

Open
ShikaSD opened this issue Jun 24, 2019 · 0 comments
Open

Access to old state to NewsPublisher and PostProcessor #88

ShikaSD opened this issue Jun 24, 2019 · 0 comments
Labels
enhancement New feature or request
Milestone
2.0

Comments

@ShikaSD
Copy link
Contributor

ShikaSD commented Jun 24, 2019 •
edited
Loading

Current implementation of NewsPublisher and PostProcessor has a signature of (Action, Effect, State) -> T?, which can be somehow limiting, when you want to diff the previous and current state.
The common suggestion to update the signature to include the previous state, e.g. (State, Action, Effect, State) -> T?, which seems to be the best idea for now.
@ShikaSD ShikaSD changed the title Add a parameter with old state to NewsPublisher and PostProcessor Access to old state to NewsPublisher and PostProcessor Jun 24, 2019
@ShikaSD ShikaSD mentioned this issue Jun 24, 2019
Open
8 tasks
@zsoltk zsoltk added the enhancement New feature or request label Jun 24, 2019
@zsoltk zsoltk added this to the 2.0 milestone Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@zsoltk @ShikaSD