Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that the module works with all types of data that the store should process #35

Open
jcookems opened this issue Mar 2, 2013 · 0 comments
Labels
Milestone

Comments

@jcookems
Copy link

jcookems commented Mar 2, 2013

We have tests (unit and the chat app) that use "normal" strings as the data passed to SocketIO. But it seems reasonable that SocketIO can accept unrestricted binary data.

We should determine what data SocketIO accepts, then make sure to cover those scenarios in the unit tests. For example:

  1. Unicode data (including Chinese Ext-B characters)
  2. Binary data (however that might be represented)
  3. Strings that include characters that are special to the serialization formats (like JSON characters that get escaped, XML escape characters, characters that are not valid in XML (0xFFFE, 0x05))
  4. JavaScript values (DateTime?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant