Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tour map overview page #1111

Closed
flibbertigibbet opened this issue Jul 8, 2019 · 3 comments
Closed

Add tour map overview page #1111

flibbertigibbet opened this issue Jul 8, 2019 · 3 comments
Assignees

Comments

@flibbertigibbet
Copy link
Contributor

flibbertigibbet commented Jul 8, 2019

Add a map state for tour overviews. In this state, the destination is listed as the tour name, and cards are presented in the sidebar for each destination in the tour, in order.

image

This is to add the map page state, with the sidebar cards; the multi-stop routing is to be implemented in #1121.

Depends on #1109.
Connects #1110 (link to this tour overview page from the tour detail page).

@flibbertigibbet
Copy link
Contributor Author

Closed in #1148.

@KlaasH
Copy link
Contributor

KlaasH commented Oct 3, 2019

While working on #1146, I realized that PR #1148 doesn't actually enable the view shown in the wireframe sceenshot above. When you click the "Map" page from a tour detail view, you get a directions page showing only the last destination on the tour, and you have to enter an origin to see the rest. The wireframe shows a route from, I assume, the first destination to the last.

Should there be a new issue for implementing that behavior, or Is it already covered by an existing one issue, e.g. #1145? If the latter, it might make sense to add a note to the existing issue.

@flibbertigibbet
Copy link
Contributor Author

That is #1126, which is in progress. Events, unlike tours, are not to be shown with any route, but only list the destinations in the sidebar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants