-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy-ready image #19
Comments
tbergmueller
added a commit
that referenced
this issue
Oct 27, 2023
Fix node_module copying in runner (copy from builder to include generated prisma-module) Run next-application directly, as yarn requires write access to FS to run a command. This may be problematic in prod environments Adding to #19
tbergmueller
added a commit
that referenced
this issue
Oct 27, 2023
In production, applications shall be run as non-root user. This adds USER 1000 to Dockerfile for homogeneous behavior btw dev and prod Adding to #19
From @pedrolucasp via Slack:
|
From #40 I'd suggest to:
|
From #41 : consider builder and runner targets; can we clean up the .next/cache linking to just have it in runner and maybe also use the runner during docker-compose (which is development) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current version of the containerized application is not suitable for deployment. We need a better, more suitable image for deploying. It might even be wise to generate one and push it into a container registry. Multi-staged builds are already being used on our Dockerfile, which is a nice step ahead.
The text was updated successfully, but these errors were encountered: