Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hrefs not being updated when using child routers #74

Open
nnscr opened this issue Feb 22, 2018 · 1 comment
Open

hrefs not being updated when using child routers #74

nnscr opened this issue Feb 22, 2018 · 1 comment
Assignees

Comments

@nnscr
Copy link

nnscr commented Feb 22, 2018

I'm submitting a bug report

  • Library Version:
    1.3.1

Please tell us about your environment:

  • Operating System:
    Arch Linux

  • Node Version:
    9.5.0

  • NPM Version:
    5.6.0

  • JSPM OR Webpack AND Version
    webpack 3.11.0

  • Browser:
    only tested in Chromium 64

  • Language:
    TypeScript 2.7.2

Current behavior:
When navigating between child routers href attributes are not updated.

Expected/desired behavior:
Well, they should be. It does work though when we replace route-href with click.trigger="router.navigateToRoute()". So this is probably a bug (or a missing configuration on the router for which I can't find documentation?)

See https://gist.run/?id=fb16ffef1d09f8b466a980ba8a1c14c0

Pay attention to the background colors. They should stay the same when navigating between the feed and the photos (every "profile" has a background color so it's easier to see the problem). So on home click on a profile, click photos, it works. Click on feed, select the other profile, click on photos again and you'll land on the wrong url.

  • What is the expected behavior?
    The href tags should update when the route parameter of the parent routers route changes (route, route!)

  • What is the motivation / use case for changing the behavior?

@Alexander-Taran
Copy link

Alexander-Taran commented Mar 15, 2018

Ok
long story short:

in gist provided
file profile/index.html

	<a route-href="feed">Feed</a>
	<a route-href="photos">Photos</a>

when navigation to another profile happens from the profile page these are not updated

@EisenbergEffect can you take a look if it's a feature or a bug.

@davismj davismj self-assigned this Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants