Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong release for DNS Challenge 2020 #656

Open
jonpodtu opened this issue Feb 22, 2023 · 3 comments
Open

Wrong release for DNS Challenge 2020 #656

jonpodtu opened this issue Feb 22, 2023 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jonpodtu
Copy link

jonpodtu commented Feb 22, 2023

🐛 Bug

Regard using the DNS-Challenge baseline, there are issues when using the newest version of the DNS Challenge repo, where the main problems occur when evaluating models, as the testdata has been removed from the repo newest release of the DNS Challenge repo.

I suggest that in line 9 in asteroid/blob/master/egs/dns_challenge/baseline/local/download_data.sh is changed from git clone https://github.com/microsoft/DNS-Challenge to git clone -b interspeech2020/master https://github.com/microsoft/DNS-Challenge so it clones the last stable release of the DNS Challenge 2020 repo.

@jonpodtu jonpodtu added bug Something isn't working help wanted Extra attention is needed labels Feb 22, 2023
@mpariente
Copy link
Collaborator

Sounds like the good solution, can you submit a PR please ?

@Rodolfo-S
Copy link
Contributor

Rodolfo-S commented May 9, 2024

Adding to this, should the name of the recipe directory be changed to reflect which version of the DNS dataset it's using (i.e. "dns_challenge_INTERSPEECH_2020" rather than "dns_challege")? This would make it so that other versions of the DNS Challenge dataset could be potentially added as their own recipes.

@mpariente
Copy link
Collaborator

Makes sense !
Please make PRs

Rodolfo-S added a commit to Rodolfo-S/asteroid that referenced this issue Jul 19, 2024
mpariente pushed a commit that referenced this issue Jul 19, 2024
…700)

* [egs] Add branch name to git clone of dns_challenge repo (#656)

* [egs] Change "dns_challenge" directory name to "dns_challenge_INTERSPEECH2020" to reflect version of dataset (#656)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants