-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong release for DNS Challenge 2020 #656
Labels
Comments
jonpodtu
added
bug
Something isn't working
help wanted
Extra attention is needed
labels
Feb 22, 2023
Sounds like the good solution, can you submit a PR please ? |
Adding to this, should the name of the recipe directory be changed to reflect which version of the DNS dataset it's using (i.e. "dns_challenge_INTERSPEECH_2020" rather than "dns_challege")? This would make it so that other versions of the DNS Challenge dataset could be potentially added as their own recipes. |
Makes sense ! |
Rodolfo-S
added a commit
to Rodolfo-S/asteroid
that referenced
this issue
Jul 19, 2024
Rodolfo-S
added a commit
to Rodolfo-S/asteroid
that referenced
this issue
Jul 19, 2024
…EECH2020" to reflect version of dataset (asteroid-team#656)
mpariente
pushed a commit
that referenced
this issue
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug
Regard using the DNS-Challenge baseline, there are issues when using the newest version of the DNS Challenge repo, where the main problems occur when evaluating models, as the testdata has been removed from the repo newest release of the DNS Challenge repo.
I suggest that in line 9 in
asteroid/blob/master/egs/dns_challenge/baseline/local/download_data.sh
is changed fromgit clone https://github.com/microsoft/DNS-Challenge
togit clone -b interspeech2020/master https://github.com/microsoft/DNS-Challenge
so it clones the last stable release of the DNS Challenge 2020 repo.The text was updated successfully, but these errors were encountered: