Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken tests, refactor for testability #21

Open
chuckadams opened this issue Nov 9, 2024 · 0 comments
Open

fix broken tests, refactor for testability #21

chuckadams opened this issue Nov 9, 2024 · 0 comments

Comments

@chuckadams
Copy link
Contributor

After #19 was merged, most tests are now broken. Some can be removed because they test systems that no longer exist, but others can be rescued.

I'd also like to see more tests in general, and more of them be unit tests rather than integration. Ideally we want to just test inputs and outputs, not have to "mock around the clock". We needn't be gentle about it either: if code needs to be refactored to make testing easier, then so much the better for the code in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant