Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: repositories.bzl seems to be missing #96

Open
sin-ack opened this issue May 7, 2024 · 1 comment · May be fixed by #102
Open

[Bug]: repositories.bzl seems to be missing #96

sin-ack opened this issue May 7, 2024 · 1 comment · May be fixed by #102
Labels
bug Something isn't working untriaged Requires traige

Comments

@sin-ack
Copy link

sin-ack commented May 7, 2024 •
edited
Loading

What happened?

In #72 a Bzlmod extension was added, but the repositories.bzl file referenced from extensions.bzl seems to be missing in the repository.

Version

Development (host) and target OS/architectures: GNU/Linux

Output of bazel --version: 7.1.1

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 1.0.0

Language(s) and/or frameworks involved: -

How to reproduce

rules_rollup/rollup/extensions.bzl

Line 3 in a66680d

load(":repositories.bzl", "rollup_repositories")

Any other information?

No response
@sin-ack sin-ack added the bug Something isn't working label May 7, 2024
@github-actions github-actions bot added the untriaged Requires traige label May 7, 2024
@jbedard jbedard assigned jbedard and unassigned jbedard May 7, 2024
@kon72
Copy link

kon72 commented May 20, 2024

This is causing bazel mod command to fail in a project that depends on rules_rollup:

$ bazel mod graph
ERROR: Error loading '@@aspect_rules_rollup~//rollup:extensions.bzl' for module extensions, requested by @@aspect_rules_rollup~//:MODULE.bazel:20:23: at /private/var/tmp/_bazel_kon/145573fc157b84d695dc97cdf5deb424/external/aspect_rules_rollup~/rollup/extensions.bzl:3:6: cannot load '@@aspect_rules_rollup~//rollup:repositories.bzl': no such file: at /private/var/tmp/_bazel_kon/145573fc157b84d695dc97cdf5deb424/external/aspect_rules_rollup~/rollup/extensions.bzl:3:6: cannot load '@@aspect_rules_rollup~//rollup:repositories.bzl': no such file. Type 'bazel help mod' for syntax and help.

I think repositories.bzl file and the corresponding part in MODULE.bazel is leftover from #77 so hopefully it's safe to be removed.
I confirmed deleting them solved the mod command failure.

@kon72 kon72 linked a pull request May 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working untriaged Requires traige
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extensions.bzl as it is unused anymore kon72/rules_rollup
3 participants
@jbedard @kon72 @sin-ack