Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Add support for assetName esbuild API #124

Open
1 task
KatSick opened this issue Feb 7, 2023 · 2 comments
Open
1 task

[FR]: Add support for assetName esbuild API #124

KatSick opened this issue Feb 7, 2023 · 2 comments
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build
Milestone

Comments

@KatSick
Copy link

KatSick commented Feb 7, 2023

What is the current behavior?

If I define assetNames in config, a new folder will be created in Bazel output, but the folder is not included in the rule's output. It means it is impossible to manage it or use it with output_dir=False.

Describe the feature

It would be great to add support for assetNames to specify the assets output folder (needed for GitLab Pages website deployment under the custom path).

In theory, we can add something like output_assets=Label() in order to get assets from esbuild

Fund our work

@KatSick KatSick added the enhancement New feature or request label Feb 7, 2023
@gregmagolan gregmagolan moved this to 📋 Backlog in Open Source Feb 7, 2023
@gregmagolan gregmagolan added the discussion needed Discussion required to progress further label Feb 7, 2023
@gregmagolan gregmagolan moved this from 📋 Backlog to 🔖 Ready in Open Source Feb 7, 2023
@gregmagolan
Copy link
Member

Hmmm. Perhaps the correct API should be out_dirs to be able to specify multiple expected output dirs. This is what the API we went with in js_run_binary.

This could be added in a non-breaking fasion.

@KatSick
Copy link
Author

KatSick commented Feb 7, 2023

sounds good to me

@alexeagle alexeagle added funding needed Contribute to https://opencollective.com/aspect-build and removed discussion needed Discussion required to progress further labels Mar 27, 2023
@gregmagolan gregmagolan added this to the 1.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build
Projects
Status: On Deck
Development

No branches or pull requests

3 participants