Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: [gazelle] package.json required in ts_project(srcs) for esm .js imports #724

Open
jbedard opened this issue Jul 17, 2024 · 0 comments
Open

[Bug]: [gazelle] package.json required in ts_project(srcs) for esm .js imports #724

jbedard opened this issue Jul 17, 2024 · 0 comments
Assignees
@jbedard
Labels
bug Something isn't working

Comments

@jbedard
Copy link
Member

jbedard commented Jul 17, 2024 •
edited
Loading

Typescript looks at the parent package.json module type to determine imports are handled. Gazelle should detect this and put package.json into ts_project(srcs).

See https://www.typescriptlang.org/docs/handbook/modules/reference.html#module-format-detection
@jbedard jbedard added the bug Something isn't working label Jul 17, 2024
@jbedard jbedard self-assigned this Jul 17, 2024
@github-actions github-actions bot added the untriaged Requires traige label Jul 17, 2024
@jbedard jbedard removed the untriaged Requires traige label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbedard