From 803671a3f2ae62ded315f66862ff5ff9b30c19ef Mon Sep 17 00:00:00 2001 From: David Venable Date: Wed, 8 Nov 2023 08:45:39 -0800 Subject: [PATCH] Some changes to the configurations for the new visibility timeout extension feature. Increase the maximum default to 2 hours, increase the maximum configurable extension to 24 hours, and rename to use the work "maximum" to remain consistent (e.g. maximum_messages). (#3604) Signed-off-by: David Venable --- .../plugins/source/s3/configuration/SqsOptions.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/data-prepper-plugins/s3-source/src/main/java/org/opensearch/dataprepper/plugins/source/s3/configuration/SqsOptions.java b/data-prepper-plugins/s3-source/src/main/java/org/opensearch/dataprepper/plugins/source/s3/configuration/SqsOptions.java index c4acd3abfd..40aeb6ffd6 100644 --- a/data-prepper-plugins/s3-source/src/main/java/org/opensearch/dataprepper/plugins/source/s3/configuration/SqsOptions.java +++ b/data-prepper-plugins/s3-source/src/main/java/org/opensearch/dataprepper/plugins/source/s3/configuration/SqsOptions.java @@ -18,7 +18,7 @@ public class SqsOptions { private static final int DEFAULT_MAXIMUM_MESSAGES = 10; private static final Boolean DEFAULT_VISIBILITY_DUPLICATE_PROTECTION = false; private static final Duration DEFAULT_VISIBILITY_TIMEOUT_SECONDS = Duration.ofSeconds(30); - private static final Duration DEFAULT_MAX_VISIBILITY_TIMEOUT_EXTENSION = Duration.ofSeconds(1800); // 30 minutes + private static final Duration DEFAULT_MAX_VISIBILITY_TIMEOUT_EXTENSION = Duration.ofHours(2); private static final Duration DEFAULT_WAIT_TIME_SECONDS = Duration.ofSeconds(20); private static final Duration DEFAULT_POLL_DELAY_SECONDS = Duration.ofSeconds(0); @@ -39,9 +39,9 @@ public class SqsOptions { @JsonProperty("visibility_duplication_protection") private Boolean visibilityDuplicateProtection = DEFAULT_VISIBILITY_DUPLICATE_PROTECTION; - @JsonProperty("max_visibility_timeout_extension") + @JsonProperty("maximum_visibility_timeout_extension") @DurationMin(seconds = 30) - @DurationMax(seconds = 3600) + @DurationMax(hours = 24) private Duration maxVisibilityTimeoutExtension = DEFAULT_MAX_VISIBILITY_TIMEOUT_EXTENSION; @JsonProperty("wait_time")