Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add httpRequest functionality to sample apps #123

Open
yathindrak opened this issue Jul 26, 2022 · 6 comments · May be fixed by #262
Open

Add httpRequest functionality to sample apps #123

yathindrak opened this issue Jul 26, 2022 · 6 comments · May be fixed by #262

Comments

@yathindrak
Copy link
Contributor

Is your suggestion related to an experience ? Please describe.

The sample apps can be improved to have the httpRequest functionality.

Describe the improvement

Currently, SDK docs contain the steps to perform HTTP request. Nevertheless, the sample apps can be further improved to have the httpRequest to showcase the flow of accessing a protected resource.
Ex: calling the basic user info endpoint

Additional context

@s-vamshi
Copy link
Contributor

s-vamshi commented Oct 8, 2024

Hey @NipuniBhagya @yathindrak I would love to work on this issue, can you please assign this to me?

@s-vamshi
Copy link
Contributor

Hey @NipuniBhagya @yathindrak ,
As my previous pr got merged, can I work on this issue, can you please assign this to me?

@pavinduLakshan
Copy link
Contributor

Hey @NipuniBhagya @yathindrak , As my previous pr got merged, can I work on this issue, can you please assign this to me?

Just assigned the issue to you @s-vamshi , feel free to get back if you need any help. Cheers!

@s-vamshi
Copy link
Contributor

hey @pavinduLakshan
i have made changes in one of the sample app
using httprequest from auth-react to fetch scim2/me info
this is how it looks, please let me know if i am on the right track
image

@pavinduLakshan
Copy link
Contributor

@s-vamshi Can you open a draft PR with your implementation please, so that we can have a look at your impl. and provide feedback?

@s-vamshi
Copy link
Contributor

hey @pavinduLakshan opened a draft pr #262
can you please review it in your free time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants