Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-bicol option also overrides -sicol option #150

Open
rambaut opened this issue Jan 31, 2022 · 1 comment
Open

-bicol option also overrides -sicol option #150

rambaut opened this issue Jan 31, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@rambaut
Copy link
Member

rambaut commented Jan 31, 2022

By default the -sicol option uses column name sequence_name to match metadata to sequence id. But if you specify a different -bicol column to match your query then -sicol also changes. I don't think this is intuitive behaviour.
@rambaut rambaut added the enhancement New feature or request label Jan 31, 2022
@rambaut
Copy link
Member Author

rambaut commented Feb 24, 2022

Further to this perhaps it would be best to have an option -idcol which specifies the column to use for matching for all the options and then -sicol and -bicol (and -icol?) are used to override this for specific cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rambaut