Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Docker gives an error when it is trying to install a package from npm #1662

Closed
arthurd2 opened this issue Sep 21, 2023 · 2 comments · Fixed by #1665
Closed

Problem: Docker gives an error when it is trying to install a package from npm #1662

arthurd2 opened this issue Sep 21, 2023 · 2 comments · Fixed by #1665
Assignees
@melaniekung
Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone
2.8.0

Comments

@arthurd2
Copy link

Hi People,
I guess theres a typ0 in the Dockerfile in the following line:

atom/Dockerfile

Line 54 in 9fd22ac

&& npm install -g npm "less@<4.0.0" \

In order to work, we need to remove the second npm in the line.
@anvit
Copy link
Contributor

anvit commented Sep 22, 2023

Thanks so much for reporting this @arthurd2!

@anvit anvit added this to the 2.8.0 milestone Sep 22, 2023
@anvit anvit changed the title Typ0 in Dockerfile Problem: Docker gives an error when it is trying to install a package from npm Sep 22, 2023
@anvit anvit added Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. labels Sep 22, 2023
@melaniekung melaniekung self-assigned this Sep 25, 2023
melaniekung added a commit that referenced this issue Sep 25, 2023
@melaniekung
Fix npm install for Docker. (#1662)
1b3a7f7
anvit pushed a commit that referenced this issue Sep 28, 2023
@melaniekung @anvit
Fix npm install for Docker. (#1662)
c870de6
melaniekung added a commit that referenced this issue Sep 28, 2023
@melaniekung
Fix npm install for Docker. (#1662) (#1665)
43a18e1
@melaniekung
Copy link
Contributor

PR: 43a18e1

@anvit anvit linked a pull request Oct 19, 2023 that will close this issue
Fix npm install for Docker. (#1662) #1665
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melaniekung melaniekung

Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

Fix npm install for Docker. (#1662) artefactual/atom
3 participants
@arthurd2 @anvit @melaniekung