Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Bug: RepositoryMatch filter is not working in combination with other filters #521

Open
fardin01 opened this issue Feb 28, 2022 · 1 comment · May be fixed by #511
Open

Bug: RepositoryMatch filter is not working in combination with other filters #521

fardin01 opened this issue Feb 28, 2022 · 1 comment · May be fixed by #511

Comments

@fardin01
Copy link

Specifying a RepositoryMatch AND a PathsExist filter does not work as expected. The ListRepos function will still fetch all the available repos, because compileFilters function does not return the correct filters.

compileFilters function first checks for RepositoryMatch and sets the FilterType to 1, then it checks for PathsExist and overwrites the FilterType to 2. So when we reach this line, repoFilters has a length of 0.
@fardin01
Copy link
Author

fardin01 commented Feb 28, 2022 •
edited
Loading

A fix is being worked on in #511.

@crenshaw-dev crenshaw-dev linked a pull request Feb 28, 2022 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: filters skipped when more than one is specified (#521) crenshaw-dev/applicationset
1 participant
@fardin01