[1.20.4] [All] Exception when removing duplicates modules on windows #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Also my ide automatically formatted files I worked in |
|
@shedaniel ready for review Tested locally on windows 10 |
|
Can you try to revert unrelated changes? |
|
I can try yes |
Edouard127
changed the title
|
@shedaniel Is there a follow-up to this pull request ? |
|
My windows desktop is not setup for development so this will take some time to test, I hope I have time to do it tomorrow |
|
This exception can also be caused by poorly-structured projects that has classes outside any package. A potential fix for this would be String sanitized = Transform.trimLeadingSlash(path.replace(File.separatorChar, '/'));
if (sanitized.contains("/")) {
String packageName = sanitized.substring(0, sanitized.lastIndexOf('/')).replace('/', '.');
modules.add(packageName);
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the system file separator by the unix file separator
/The culprit is
Paths.get(path)at https://github.com/architectury/architectury-transformer/pull/25/files#diff-2ffc22c302a4c43a8045165c38bb130d608b62de4398f8b53db8a177b4987434R248 which converts the sanitized path back to a system path. The fix is really just to convert it back to unix pathsCloses #24