Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test: tests_02_allocation_counters (timeout) #215

Open
weissi opened this issue May 11, 2020 · 6 comments
Open

flaky test: tests_02_allocation_counters (timeout) #215

weissi opened this issue May 11, 2020 · 6 comments
Labels
area/testing Improvements to tests.

Comments

@weissi
Copy link
Member

weissi commented May 11, 2020

14:25:57 Running test suite 'tests_02_allocation_counters'
14:25:57 Running test 'test_01_allocation_counts.sh'... Build timed out (after 20 minutes). Marking the build as failed.
14:31:03 $ ssh-agent -k
@weissi weissi added the area/testing Improvements to tests. label May 11, 2020
@weissi
Copy link
Member Author

weissi commented May 11, 2020

they might legitimately take longer than 6 minutes but if that's the case we should make CI give us more minutes.

@Lukasa
Copy link
Contributor

Lukasa commented May 11, 2020

I think it legitimately takes longer than 6 minutes because it has to do a complete release build.

@weissi
Copy link
Member Author

weissi commented May 11, 2020

Cool @tomerd can we get extra CI time :)

@tomerd
Copy link
Member

tomerd commented May 11, 2020

yea how much do we need?

@Lukasa
Copy link
Contributor

Lukasa commented May 11, 2020

Does 30 mins work?

@tomerd
Copy link
Member

tomerd commented May 12, 2020

we could try. long term, if we see the test suite keeps growing we may need to split into "short" and "long" tests where we run the "long" ones only when we feel the PR is close to ready so we reduce the amount of times they run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Improvements to tests.
Projects
None yet
Development

No branches or pull requests

3 participants