Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Actors: Add option for using Poetry setup #247

Open
vdusek opened this issue Dec 4, 2023 · 0 comments
Open

Python Actors: Add option for using Poetry setup #247

vdusek opened this issue Dec 4, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@vdusek
Copy link
Contributor

vdusek commented Dec 4, 2023

Description

  • Currently, the apify create process only provides a Pip setup by default.
  • This enhancement aims to offer users the flexibility to choose between Pip and Poetry setups during the creation process.

Proposed Changes

  • Update the Dockerfile.
  • Remove requirements.txt and add pyproject.toml (and optionally poetry.toml) instead of it.
  • Take a look at the Beautiful Soup Scraper for inspiration.

Open questions

  • Figure out how to not make duplicates of the current Python code in the templates.

Motivation

  • User request on Discord.

Current situation

  • If users want to use Poetry for their Actor setup, they have to do the update manually. They can take a look at the Beautiful Soup Scraper for inspiration where Poetry is integrated.
@vdusek vdusek added enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team. labels Dec 4, 2023
@vdusek vdusek self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

1 participant