Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] integrate audit log framework for Iceberg REST server #5556

Open
FANNG1 opened this issue Nov 12, 2024 · 1 comment · May be fixed by #5580
Open

[Improvement] integrate audit log framework for Iceberg REST server #5556

FANNG1 opened this issue Nov 12, 2024 · 1 comment · May be fixed by #5580
Labels
improvement Improvements on everything

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Nov 12, 2024

What would you like to be improved?

#3973 add an audit log framework and provides a default audit writer, but it couldn't work with IcebergRESTServer, the main reason is the Iceberg REST event is defined in iceberg-rest-server module, while the default writer defined in core module.

How should we improve?

To make the default audit works for both Gravitino server and Iceberg REST server, I propose to add an auditInfo interface, all events should implement it, the default audit log writer could get the audit info from all the event.

@FANNG1 FANNG1 added the improvement Improvements on everything label Nov 12, 2024
@FANNG1
Copy link
Contributor Author

FANNG1 commented Nov 12, 2024

welcome comments, cc @hanwxx @jerryshao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant