Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improved meta support for consul in dubco-spi-extensions 3.3.x #14870

Open
4 tasks done
eduosi opened this issue Nov 7, 2024 · 3 comments
Open
4 tasks done
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@eduosi
Copy link

eduosi commented Nov 7, 2024

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

In version 3.3.0, dubco-metadata-report-consul cannot map services and apps at all, cannot subscribe to services, and the corresponding implementation code is not found in the 3.3.1 branch.

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@eduosi eduosi added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Nov 7, 2024
@heliang666s
Copy link
Contributor

heliang666s commented Nov 7, 2024

Hello thanks for the feedback, the implementation of consul is in dubbo-spi-extension, and the specific usage method can be found in dubbo-spi-samples. There is already an issue that reflects the same problem, and a PR has been filed. If you still can't use it after referring to it, please give us a detailed error log.@eduosi

@eduosi
Copy link
Author

eduosi commented Nov 7, 2024

Hello thanks for the feedback, the implementation of consul is in dubbo-spi-extension, and the specific usage method can be found in dubbo-spi-samples. There is already an issue that reflects the same problem, and a PR has been filed. If you still can't use it after referring to it, please give us a detailed error log.@eduosi

图片 图片 Because there's no rewriting methods on the interface MetadataReport registerServiceAppMapping ConsulMetadataReport, not registered service and application of mapping relation with the consul; The method getServiceAppMapping in the MetadataReport interface is also overridden so that the mapping between the fetching service and the application is always empty.

dubbo-test.zip

This is a simple demo that uses consul for both the registry and the metadata center

  1. Change the registry address and metadata center address in aplication.yml to the addresses of consul.
  2. cd dubbo-test-parent && mvn clean install
  3. run dubbo-test-provider
  4. run dubbo-test-consumer
  5. go to 'http://127.0.0.1:8081/test/echo'

@eduosi eduosi changed the title [Feature] Improved meta support for consul in dubco-spi-extensions 3.3.1 [Feature] Improved meta support for consul in dubco-spi-extensions 3.3.x Nov 8, 2024
@eduosi
Copy link
Author

eduosi commented Nov 8, 2024

Hello thanks for the feedback, the implementation of consul is in dubbo-spi-extension, and the specific usage method can be found in dubbo-spi-samples. There is already an issue that reflects the same problem, and a PR has been filed. If you still can't use it after referring to it, please give us a detailed error log.@eduosi

Metadata support for consul apache/dubbo-spi-extensions#560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

2 participants