Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

自動レビュー #34

Open
pizzacat83 opened this issue May 5, 2020 · 1 comment
Open

自動レビュー #34

pizzacat83 opened this issue May 5, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone
Road to Perfect

Comments

@pizzacat83
Copy link
Member

pizzacat83 commented May 5, 2020 •
edited
Loading

レビューをする上でいろいろ自動化できそうなポイントがあり，自動化できると楽しい
検出自体はESLint等の自作プラグインとして実現できても良くて，ただプルリクにレビューコメントをつけてくれるサービスを導入したい
あんまりいっぱい導入しても重複が出たりチェック項目が増えたりとつらいので，一本に絞った方が良さそう

検出したいもの

  • ESLint
  • function.json の runOnStartup
  • slack.admin の使用

面白そうなサービス
@pizzacat83 pizzacat83 added the enhancement New feature or request label May 5, 2020
@pizzacat83 pizzacat83 added this to the Road to Perfect milestone May 5, 2020
@pizzacat83 pizzacat83 mentioned this issue May 5, 2020
Open
6 tasks
@pizzacat83
Copy link
Member Author

レビュー時はESLintのコメントignoreを外すと良さそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Road to Perfect
Development

No branches or pull requests
1 participant
@pizzacat83