Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field constraints not specified correctly #77

Closed
mhidas opened this issue Aug 23, 2023 · 0 comments · Fixed by #83
Closed

Field constraints not specified correctly #77

mhidas opened this issue Aug 23, 2023 · 0 comments · Fixed by #83
Assignees

Comments

@mhidas
Copy link
Collaborator

mhidas commented Aug 23, 2023

In the TableSchema standard, constraints such as a fields being required or unique need to be specified within a constraints property (see documentation).

In all the dataresource.yaml files specify properties like required or unique directly under each field, which is allowed, but it means they don't have the intended meaning, i.e., frictionless will not consider them when validating the data.

What needs to be done is for any field that has required: true or unique: true, these need to be moved into a constraints property.
E.g. this

  - name: SAMPLEDEPTH_M
    type: string
    required: true

becomes

  - name: SAMPLEDEPTH_M
    type: string
    constraints:
      required: true

Note that specifying required: false or unique: false is not necessary as these are the case by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants