Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit "MaxLength" in observable items list #1366

Open
atcooper1 opened this issue Jun 17, 2024 · 4 comments
Open

Unable to edit "MaxLength" in observable items list #1366

atcooper1 opened this issue Jun 17, 2024 · 4 comments

Comments

@atcooper1
Copy link
Collaborator

Have come across some errors in the MaxLength data field in the the Observable items list, however data officers are currently unable to edit/correct this field.
e.g. Natator depressus has a Max length of 1200 cm - this should say 120 cm.

@bpasquer
Copy link
Contributor

bpasquer commented Jun 17, 2024

The MaxLength data field of the Observable Item view page is part of the "Other Attributes" section. This section contains historical attributes that were migrated from IMASBioDiv, and are kept for reference, but are not used by the software.
For example, NRMN uses LMax which is computed from observations instead of Maxlength in the templates .

That being said it could be useful to see LMax alongside Maxlength, so that you have a feel of the quality of the data in the database - ie any outliers would be easily spotted

@atcooper1
Copy link
Collaborator Author

Can we amend incorrect MaxLength values stored (such as the example given above)? Max length is an important attribute (especially when few observations are recorded for a species therefore Lmax is not necessarily representative)?

@bpasquer
Copy link
Contributor

Yes we can amend them. We only need a list of :
observable_item_id, observable_item_name, current LMax, new LMax
Thanks

@bpasquer
Copy link
Contributor

From Catch-up discussion(2024-06-27)
Because MaxLength is stored in JSONB obs_item_attribute in the observable_item_ref table it is technically impossible to edit.
The proposed solution is to store MaxLength in a separate column in the table. This will also apply to the other attribute stored in the jsonb "OtherGroups"

Additionally we've agreed to update MaxLenght values using data from Fishbase.

@bpasquer bpasquer added this to the Maintenance - Software milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants