Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updateCellId api bug #3816

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

JackyChen02
Copy link
Contributor

@JackyChen02 JackyChen02 commented Jul 27, 2023

Description

When the new and old Id are the same and this API is also called, the cell will disappear

Motivation and Context

https://codesandbox.io/s/mo-ban-forked-xxcx2s?file=/src/App.tsx

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. PR: unreviewed PR does not have any reviews. pkg:x6 labels Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3816 (ac64eb7) into master (8835ee6) will increase coverage by 0.01%.
Report is 41 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3816      +/-   ##
==========================================
+ Coverage   10.34%   10.36%   +0.01%     
==========================================
  Files         180      180              
  Lines       10515    10507       -8     
  Branches     2561     2558       -3     
==========================================
+ Hits         1088     1089       +1     
+ Misses       9338     9329       -9     
  Partials       89       89              
Flag Coverage Δ
x6 10.36% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/x6/src/model/model.ts 1.63% <0.00%> (ø)

... and 4 files with indirect coverage changes

@x6-bot x6-bot bot added PR: reviewed-approved PR has reviewed and got Approve from everyone. and removed PR: unreviewed PR does not have any reviews. labels Jul 28, 2023
@NewByVector NewByVector merged commit dbd0219 into antvis:master Jul 28, 2023
23 of 24 checks passed
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: reviewed-approved PR has reviewed and got Approve from everyone. labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:x6 PR: merged PR has merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants