-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration screen #87
Comments
Should we keep this open for the other 2 features or wait for them to be implemented in AFJ? |
Maybe create separate issues for it? I did notice some issues with the current implementation:
Screen.Recording.2022-10-06.at.15.35.36.movScreen.Recording.2022-10-06.at.15.35.14.mov@janrtvld @rapaktech what do you think? |
Fixed that one.
Jim and i talked about it and we just totally forgot about it haha.
Great solution. I think we can assume that most people that find out about the cmd+k menu know what they are doing so all these options wouldn't really confuse them.
This option seemed the best as i assumed it would result in issues if you'd let the user change settings halfway through the demo. Now that we've implemented it i noticed this works just fine so i like this change. Are you able to pick these up, @rapaktech? I can help you with the currently selected option as that might be a bit more tricky but the other two should be pretty easy. |
Quick question. We already have resetState that is basically resetDemo - resetConfig, and resetDemo that is resetState + resetConfig. So now I should rewrite resetDemo to something that essentially is resetConfig, correct? |
It would be nice to add a configuration screen (accessed by cmd+k) that allows to configure which features to use for the demo. This way you can use the demo with some of the new feautres, without breaking interop with old wallets. Kind of like flags in your browser (very hidden, but possible to change if you know what you're doing).
The features I'm currently thinking of:
We can add custom configuration to the cmd/ctrl+k screen like we already have with change theme (see screenshot)
The text was updated successfully, but these errors were encountered: