Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict with other AHK script, that is showing tooltip #8

Open
zldrq opened this issue Aug 1, 2015 · 5 comments
Open

conflict with other AHK script, that is showing tooltip #8

zldrq opened this issue Aug 1, 2015 · 5 comments

Comments

@zldrq
Copy link

zldrq commented Aug 1, 2015

i have version with this pull request merged https://github.com/andreberg/PoE-Item-Info/pull/5/files
so, symptoms:
a also have this script run:
http://exiletools.com/pricemacro.html
it is good.

but when i have yours turned on, when i press ctrl+p (hotkey for poe_item_lookup.ahk) it is behaving weird: your tooltip is appearing for couple of seconds, but needed tooltip is not showing, it flickers fast and disappears. when i start mashing ctrl+p, keep it pressed for some time etc, tooltip of poe_item_lookup.ahk is finally showed and it is in monospace font (font and size settings from your script), as opposed to what i have without poe-item-info running. actually i like the view of the tooltip, but it is hard to force it to appear.

one more symptom: also i have dictionary program, that is called when you press ctrl+c twice with word selected. and when i'm pressing ctrl+p (sic) several times, this program opens and tries to translate item info. looks like ctrl+p is treated as ctrl+c for some reason. i even have guesses, what reason it is: it copies info to clipboard..
may be you will consider adding option to reassign hotkey for you script?

so anyways, that's the way i struggle! ^__^
can't say it is convenient, but it is remotely acceptable anyway.

@HiPoEGH
Copy link

HiPoEGH commented Aug 7, 2015

This is a problem with the OTHER script, not hazy's.
To possibly fix this, or rather a workaround, find the line "Send ^c" and comment it out.
The idea is to then use yourself CTRL+C, and use CTRL+P to price an item.

@zldrq
Copy link
Author

zldrq commented Aug 8, 2015

@Hixxie i am not agree. it is THIS script, that uses standard ctr+c key combination in a peculiar way. it is expected to copy something to buffer. and it does it in PoE even: copies text in chat for example. so redefining it is a bad manners.

@Tvangeste
Copy link

Just FYI, this script does nothing with redefining or messing with Ctrl-C functionality. It is a built-in feature of the game to copy item info into clipboard when user presses Ctrl-C. All this script does is monitoring the clipboard changes and acting accordingly.

@zldrq
Copy link
Author

zldrq commented Aug 8, 2015

i understand the point but.
you even saying yourself, it "acts accordingly". i'd rather say it interacts. it adds the behavior, that messes the way other agents using the standard poe's ctrl+c work. if you will, it injects itself in the midst of interaction.

i'm not raging here or anything. i'm just pointing -- it is wrong way of doing things.
there at least has to be an option that turns off monitoring, defines the shortkey to, say, ctrl+shift+c, that will press ctrl+c and call the further script. that way ctrl+c behavior will stay unaffected

@Dracbjorn
Copy link

They are both correct zldrq. Even without any macros running at all. Control + C is a normal Windows hotkey that allows you to copy something into your clipboard (files, text, pictures, etc).

Path of Exile developers have kindly built in the functionality to press Control + C while hovering over any item in order to copy details related to that item into your clipboard. If you were to disable all your macros (Item info and the Price check), and then go into the game and press Control + C on an item, then open a text editor and press Control + P, you would see the items details are pasted.

All hazy's macro does is wait for data to be copied into your clipboard, it then takes that data, parses it, re-formats it, and then puts that reformatted text into a tool-tip display.

Now, the pricecheck macro is doing something a little weird. It is initiated by pressing Control + P; however, what that is "actually" doing is sending Control + C to the system. So Hazy's macro is not starting because you press Control + P. It is kicking off because the price check macro is pressing Control + C behind the scenes. You think you are pressing Control + P when in reality it is remapping that to send Control + C which in turn copies that items information into your clipboard. When this happens, Hazy's script sees that new data has been copied into the clipboard and immediately trys to parse it to display a tooltip for you. Hazy's script is doing exactly what it is suppose to do.

The issue you are having is that both macros are trying to parse, reformat, and display the contents of your clipboard simultaneously any time that the contents are changed. Hazy's is quicker and doesn't have to go to the internet to look information up so it displays first, then shortly after the pricecheck displays on top of the item info tooltip.

What Hixxie is recommending (and it is a great idea, I didn't think of that) is to remove the line in the pricecheck tool that maps Control + P to Control + C. Instead, essentially tell it to parse the current clipboard contents whenever you press Control + P rather than copying new information into it through the remapping process. So you would then use Control + C to copy the items contents into your clipboard (Which will pop up Hazy's tool-tip momentarily). Then afterwards press control + P and it will parse the text from the last item you copied into your clipboard. It will require pressing two hotkeys in order for it to work, but it gets around them conflicting with one another simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants