Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for consistency of dimensions of added points #2

Open
ancestor-mithril opened this issue Apr 27, 2022 · 0 comments
Open

Check for consistency of dimensions of added points #2

ancestor-mithril opened this issue Apr 27, 2022 · 0 comments

Comments

@ancestor-mithril
Copy link
Owner

ancestor-mithril commented Apr 27, 2022 •
edited
Loading

  • Points are given as STL vectors and their size should be checked to be the same

  • KDTree/KDTree.cpp

    Line 32 in 576edc9

    const auto min = std::min(a.size(), b.size());
    we do not need this check if all points have the same dimension
ancestor-mithril added a commit that referenced this issue Apr 30, 2022
@ancestor-mithril
Improving KDTree according to #2
496e7a3 
* Using one dimension for all the points
* Check for consistency to be added
* Removing checks for dimension from retrieval and distance functions
* Improving creation of KDTrees by removing the need for a separate structure for all the indices
* Added implementation for nearest points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ancestor-mithril