Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Markdown (tables) format #1340

Open
julien-deramond opened this issue Sep 18, 2024 · 2 comments · May be fixed by #1353
Open

New Markdown (tables) format #1340

julien-deramond opened this issue Sep 18, 2024 · 2 comments · May be fixed by #1353

Comments

@julien-deramond
Copy link
Contributor

julien-deramond commented Sep 18, 2024

Context

I’ve been exploring Style Dictionary but haven't come across a built-in feature to generate Markdown files, nor issues or PRs mentioning it. I'm not familiar with all the features, so I've maybe missed something :)

While this might be a niche use case, I am currently in a situation where I need to generate Markdown tables from the JSON files. In addition to generating Android, iOS, and web files, I also need Markdown tables to reference in documentation.

After some experimentation, I was able to create a basic solution using the registerFormat method. Although it's a rough implementation and only tested for simple cases, it works as a proof of concept. Here's the snippet I used:

StyleDictionary.registerFormat({
  name: 'markdown',
  format: async ({ dictionary, options }) => {
    return (
      '| Name | Value | Type |\n' +
      '| ---- | ----- | ---- |\n' +
      dictionary.allTokens
        .map(function (token) {
          return `| ${token.name} | ${
            options.usesDtcg ? JSON.stringify(token.original.$value) : token.original.value
          } | ${token.original.type} |`
        })
        .join('\n')
    )
  },
})

Proposal

If there's currently no feature for generating Markdown tables output, would you be open to adding this as a new format? I’d be happy to refine the code further and submit a proper PR if there’s interest in supporting Markdown tables export as part of the project.

Let me know your thoughts, and I'd be glad to contribute!

@jorenbroekema
Copy link
Collaborator

Yeah this is definitely a welcome contribution, although I would also add the following props:

  • description (reads from token.$description or token.comment (legacy) property)
  • original (reads from token.original.value/token.original.$value) -> can be left empty if it's the same as $value/value

We can marginally improve it with other fields too, more nice-to-haves and takes a bit more work

  • Reference chain, shows the entire chain of references that lead to the resolved value
  • Value preview e.g. for colors putting a small color box div prefix, maybe some other token types can also show value previews

@vprothais
Copy link
Contributor

For the color preview you might take advantage of github and gitlab not standardized markdown. If you write a color between backtick : #ff0000 they show a little colored box (as you can see).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants