Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7.3. error #2

Open
Eimis opened this issue Jul 6, 2016 · 3 comments
Open

Python 2.7.3. error #2

Eimis opened this issue Jul 6, 2016 · 3 comments

Comments

@Eimis
Copy link

Eimis commented Jul 6, 2016

Hey :) I noticed that when get_by_ekey_or_404() is used with Python 2.7.3 it fails on struct.unpack() method, probably because of from __future__ import unicode_literals. We had your library on production, so I had to apply a dirty monkeypatch and I'm not actually sure if this will fix the bug, but you might want to look into this :) This is the small code change: Eimis@9952f23

@amitu
Copy link
Owner

amitu commented Jul 8, 2016

:-)

Thanks for reporting and fix. Will implement it and release soon.

@amitu
Copy link
Owner

amitu commented Jun 4, 2017

@jatinderjit please do this.

@jatinderjit
Copy link
Collaborator

@Eimis I'm unable to reproduce the issue. Though the string formats we used struct.pack and struct.unpack inconsistently, but the struct functions seem to handle them regardless of the format (tested in Python 2.7.3 and Python 3.5.2)

Could you provide a specific case where you faced this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants