Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support VideoJS v8 #1048

Open
4 of 6 tasks
amclin opened this issue Feb 15, 2023 · 5 comments
Open
4 of 6 tasks

Support VideoJS v8 #1048

amclin opened this issue Feb 15, 2023 · 5 comments
Labels
dependencies Pull requests that update a dependency file enhancement help wanted

Comments

@amclin
Copy link
Owner

amclin commented Feb 15, 2023 •
edited
Loading

When VideoJS v8 is used, unit tests fail to pass. See #1045

https://videojs.com/guides/videojs-7-to-8/

Things to investigate:
@amclin amclin added enhancement help wanted dependencies Pull requests that update a dependency file labels Feb 15, 2023
@amclin amclin mentioned this issue Feb 15, 2023
Open
@amclin
Copy link
Owner Author

amclin commented Feb 15, 2023

videojs.extend() is not being used. We're already using the extends keyword instead

@amclin
Copy link
Owner Author

amclin commented Feb 15, 2023

None of the newly deprecated functions are used in this plugin

@amclin
Copy link
Owner Author

amclin commented Feb 15, 2023 •
edited
Loading

The following old deprecated functions might be used in unit tests:

  • hasClass
  • getAttributes

The following old deprecated methods are used in the plugin:

  • plugin

@amclin
Copy link
Owner Author

amclin commented Feb 15, 2023

The firstplay event is not used in this plugin

@amclin
Copy link
Owner Author

amclin commented Feb 15, 2023

This plugin is not currently providing any logic around aria attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amclin